Skip to content

Conversation

balajis-qb
Copy link
Contributor

@balajis-qb balajis-qb commented Aug 12, 2025

Description

Linked issue: #5759

Problem
As mentioned in the linked ticket, we are having an issue when the user tries to clear the startDate value (when the endDate is available) using the date input, suddenly the datepicker becomes unresponsive. User can't see any value in the date input and they won't be able to select any new value from the date picker popup also.

Changes

  • Update Input Value get logic to return empty string only when both startDate & endDate is null. Because the current logic is returning empty string when the startDate is not available regardless of checking the existence of the endDate
  • Update Input change logic to properly handle start date change when endDate is available. It'll either set the startDate by retaining the endDate (if its less than the existing endDate) or set the startDate by clearing the endDate (If the existing endDate is less than the current startDate).
  • Update the Calendar Popup selection logic to properly handle the update of start date when the endDate is available

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

…election properly

- Update Input Value get logic to return empty string only when both startDate & endDate is null.
- Update Input value change logic to properly set startDate and reset endDate when the newly entered startDate is greater than the existing endDate
- Handle the Calendar date selection also properly when the startDate is null.

Closes Hacker0x01#5759
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.20%. Comparing base (9beb8c5) to head (cf2956b).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5782   +/-   ##
=======================================
  Coverage   97.19%   97.20%           
=======================================
  Files          30       30           
  Lines        3385     3393    +8     
  Branches     1429     1435    +6     
=======================================
+ Hits         3290     3298    +8     
- Misses         93       95    +2     
+ Partials        2        0    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martijnrusschen martijnrusschen merged commit 9b81282 into Hacker0x01:main Aug 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants